Fix for Error while adding a new child to a workitem [#97] #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your work. This bug has already been fixed in commit 0f0c7bd. Please pull |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error is not in the addChild method of the workitem.
it's in the _addChildren method,
cur_child_ids = [cur_child.identifier for cur_child in cur_children]at this line when we say
cur_child.identifier, we will get error if cur_child is None.This happens if the workitem doesn't have any children initially.
The issue is probably because we have used a list comprehension, which doesn't care if the iterable object is empty and that could be fixed with a simple check.